Move hardcoded addresses to addresses.ts#53
Open
paoloswap wants to merge 2 commits intocryptoalgebra:masterfrom
Open
Move hardcoded addresses to addresses.ts#53paoloswap wants to merge 2 commits intocryptoalgebra:masterfrom
paoloswap wants to merge 2 commits intocryptoalgebra:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all addresses scattered in various file to a single file (single point of "truth"): addresses.ts
Also the blockchain explorer address was hardcoded and now taken from App.tsx
defaultChain.This allows to make a new branch based on master and easily update addresses in just these 2 files:
There are still some hardcoded addresses in SwapChart/index.ts that should be removed, but this could be done in a separate commit/PR.