Skip to content

Conversation

@jcatrysse
Copy link

Defect: make plugin compatible with additional_tags
Defect: issue_recuurent throws an error on the Custom Fields page

@cryptogopher
Copy link
Owner

Thank you for the PR.

As for compatibility with the additional_tags plugin, if I understand correctly, the proposed fix is commit 9fd754a from the issue30 branch. This will not be included in the master branch for the reasons described in the discussion here: https://it.michalczyk.pro/issues/30

I will comment on other commits as soon as I have time to take a closer look at them. It would also be good if each change were sent as a separate PR.

@jcatrysse
Copy link
Author

Thank you.
I will see whether it is possible to provide a solution that permits both patch methods, based on a configuration. This will enable users to choose between the two methods, with the current recommended method serving as the default.

@cryptogopher
Copy link
Owner

Personally, I believe it is more worthwhile to spend time working on additional_tags to use prepend+super instead of alias_method.

@jcatrysse
Copy link
Author

Personally, I believe it is more worthwhile to spend time working on additional_tags to use prepend+super instead of alias_method.

Multiple plugin developers / vendors all use the alias method, and I believe they will not be changing anytime soon. I use the Redmineup series of plugins, and all their plugins are still on the old method.

@cryptogopher
Copy link
Owner

cryptogopher commented Nov 17, 2025

Still, upgrading to super is a more rational solution than downgrading to alias_method.
Redmine developer considers it

quite simpler and cleaner

https://www.redmine.org/boards/3/topics/58309?r=58800#message-58800

The additional_tags developer considers the super method

the modern, preferred way

alphanodes/additional_tags#9 (comment)

It would be worth more spending time improving stubborn dependencies that force the use of alias_method on others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants