KC_HOSTNAME needs to be the full URL since hostname v2

[SailReal]

In #121 we partially fixed it by adding the scheme but missed to set the path as well.

See https://www.keycloak.org/server/hostname for further info.

[coderabbitai]

Walkthrough

The script version in assets/js/hubsetup.js is bumped from 9 to 10. The KC_HOSTNAME environment variable configuration is modified to use the raw publicUrl value instead of automatically prefixing it with https:// for non-development modes. This change affects both Docker Keycloak service configuration and Kubernetes Keycloak deployment configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• KC_HOSTNAME configuration change applied consistently across Docker and Kubernetes environments suggests homogeneous edits
• Single file modification with straightforward URL handling logic change
• Consider verifying that the raw publicUrl format is appropriate for Keycloak in all deployment scenarios (dev and non-dev modes)
• Ensure the removal of the automatic https:// prefix doesn't introduce protocol-related issues or break existing integrations expecting prefixed URLs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: updating KC_HOSTNAME to be the full URL to comply with Keycloak hostname v2 requirements, which aligns with the changeset modifications.
Description check	✅ Passed	The description is directly related to the changeset, explaining that a previous fix missed setting the path and references Keycloak hostname v2 documentation, which contextualizes the KC_HOSTNAME changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/fix-keycloak-url

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7595e0c and 5a67c74.

📒 Files selected for processing (1)

• assets/js/hubsetup.js (3 hunks)

🔇 Additional comments (3)

assets/js/hubsetup.js (3)

115-115: LGTM!

The script version bump from 9 to 10 correctly tracks this configuration change.

---

777-778: LGTM!

The KC_HOSTNAME configuration for Kubernetes is consistent with the Docker Compose implementation (line 454), both now using the full publicUrl for Keycloak hostname v2 compatibility.

---

454-454: Implementation aligns with Keycloak hostname v2 requirements.

The change to use the raw publicUrl (with scheme and path) correctly implements Keycloak hostname v2, which requires a full URL. Setting null for development mode is appropriate.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}