Rebalance to prevent channel going below AR-OUT-Target[2]#312
Open
BhaagBoseDK wants to merge 3 commits intocryptosharks131:v1.9.0from
Open
Rebalance to prevent channel going below AR-OUT-Target[2]#312BhaagBoseDK wants to merge 3 commits intocryptosharks131:v1.9.0from
BhaagBoseDK wants to merge 3 commits intocryptosharks131:v1.9.0from
Conversation
Collaborator
BhaagBoseDK
commented
Jul 29, 2023
- Use selected outbound channels at run time.
- Check if rebalance required for inbound at run time. New status added AR-Not-Required
- Update in and out channel balances correctly taking into account multiple channels and MPP. Specially required for outbound to avoid channel dipping below AR-OUT-Target
- Make channel selection for outbound a bit conservative, only use local balance without considering unsettled balance (i.e. a lower Local Balance). This ensure outbound channel does not end up with excessive unsettled HTLCs, all of which can settle and resulting in channel dropping below AR-OUT. This change reduces but does not completely eliminates the channel dropping below AR-OUT since we run multiple rebalances in parallel and check is only made once one of the rebalance succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.