Add tags to channels#314
Draft
proof-of-reality wants to merge 41 commits intocryptosharks131:v1.9.0from
Draft
Conversation
Migration 0037 ensures each setting is available in settings table
proof-of-reality
commented
Aug 6, 2023
proof-of-reality
commented
Aug 7, 2023
This allows splitting multiple configurations into multiple groups
Get default LNDg settings instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to manage channels in a bulk
*Nice to have for future versions:
Features/rules added with this:
Afrom LNDg group to a new groupG, channelAis removed from groupLNDgAto a new groupH,Awill belong to groupGandHsimultaneouslyAfrom groupHandG,Awill return toLNDg1.1. It's allowed to create a group for
ARand another forAF1.2. It's allowed to split
ARorAFinto further more groups with the condition of: channelAcannot be in groupGandHif both groups have a single setting in common. Say:G->AR-Time:5andH->AR-Time:2(except Enabled settings)1.3. In contrast to 1.2 if you add some channels to a rebalancer group
Gbut do NOT assign any rebalance settings to it, the rebalancer will act as if none of these channels were assigned to the newly created group and will get AR settings fromLNDginstead. (The rebalance would get triggered with theLNDgdefault settings)1.4. GUI/LND settings and AR-Workers are owned by
LNDggroup. (can be changed in the future)Summary: Any group settings can be split into multiple groups if and only if channels within those same groups doesnt share any common setting