Feat: SSE POST Events for lcov dump and #1498
Closed
GalloDaSballo wants to merge 9 commits intocrytic:masterfrom
Closed
Feat: SSE POST Events for lcov dump and #1498GalloDaSballo wants to merge 9 commits intocrytic:masterfrom
GalloDaSballo wants to merge 9 commits intocrytic:masterfrom
Conversation
- Uses broadcast TChan to properly handle SSE client connections - Sends CloseEvent when all workers stop - Preserves our custom endpoints (dump_lcov, reload_corpus) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Experimental: SSE lcov and corpus_reuse + fix to SSE Bug
GalloDaSballo
requested review from
arcz,
elopez and
gustavo-grieco
as code owners
Collaborator
There was a problem hiding this comment.
Is this file necessary?
Author
There was a problem hiding this comment.
Is this file necessary?
No, I added it to generate builds on main
Collaborator
There was a problem hiding this comment.
I think once it is here as a PR, you don't need this file and can be removed. Perhaps @elopez can confirm this.
Collaborator
|
This will be replaced by #1502, once all the commands are there. |
Collaborator
|
Both commands were already implemented in #1502, so I'm closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature:
Intoduces a way to trigger an lcov coverage report to be generated, as well as having echidna reload all corpus files.
Usage:
NOTE: Both require the corpus folder config and SSE to be active:
ECHIDNA_COMMAND --server PORT --corpus echidnaPOST: /dump_lcovwill return an lcov file that was added to the corpus folderPOST:/reload_corpus` trigger a reload of all corpus files to update the in-memory corpusTesting
I've built from our own fork and ran here:
https://staging.getrecon.xyz/shares/74b7786e-71f0-4878-903b-ce9213aba25c
The lcov allows us to build the coverage chart you see