Add an option to make disassembly more forgiving #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyevmasm/evmasm.py
Outdated
|
|
||
| if silent: | ||
| if opcode not in instruction_table: | ||
| instruction = copy(instruction_table[opcode]) |
There was a problem hiding this comment.
Should this just get instruction_table[0xfe] for INVALID? Also is there something in the yellow paper that describes the behavior when an unimplemented instruction is run? Just want to make sure it's semantically the same as INVALID, but I don't see anything.
There was a problem hiding this comment.
Opps I ment to get 0xfe.
Unimplemented instruction is defined in the yellow (if I remember correctly) as the same as an INVALID. Only diff is that it may get redefined I guess ..
There was a problem hiding this comment.
try:
instruction = copy(instruction_table[opcode])
except KeyError:
if silent:
instruction = copy(instruction_table[0xfe])
else:
raise
??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration...
Added "silent" to disassemble_one, disassemble_all, disassemble so it returns an INVALID when undefined opcode or a zero completed operand when no more data in bytecode.
(Also it adds a copy.copy there. May be a bug not to do it because several disassemblies? will be using the same Instruction instance? )