Skip to content

Conversation

@Nastyst16
Copy link

@Nastyst16 Nastyst16 commented Jul 7, 2025

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Laboratory 12 from 32bits to 64 bits

Description of changes

Updated all the tasks to 64bits:

  • updated binaries
  • updated makefiles
  • tested the changes
  • updated the documentation, readmes
  • "feeling-chained" task remains on 32bit due to didactic reasons

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Functionally, most of the tasks seem alright. I'll test them more thoroughly after you do the following:

  • Change your line endings from DOS (\r\n) to Unix (\n). Use dos2unix <file-name>.
  • Look at the linter failures [1] and fix them
  • Make all .sh scripts executable again. I think this and the first error come from WSL, which by default adds DOS line endings and mounts everything as rw-r--r--.
  • Recompile the binary for feeling-chained to 64 bits
  • rip-my-buffers-off/solution/exploit.sh still uses the 32-bit address and offset. Update it like solve.sh
  • Squash your commits into a single one and reword it like so:
labs/lab-12: Add 64-bit version

<Describe your changes here>

<Your signed-off-by line here>

Let me know if you have any questions.

[1] https://github.com/cs-pub-ro/hardware-software-interface/pull/129/checks

* Updated C sources, exploits and build scripts to 64-bit
* Normalised line endings to Unix LF
* Restored executable bits on shell scripts
* Fixed typo in indirect-business README
* Updated rip-my-buffers-off exploit with 64-bit addresses

Signed-off-by: Cristian Nastase <cristiannastase16@gmail.com>' && git reset --soft origin/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants