HMP-490: fixes production.rb and makes solr host configurable#58
Merged
remillet merged 1 commit intocspace-deployment:mainfrom Mar 16, 2026
Merged
HMP-490: fixes production.rb and makes solr host configurable#58remillet merged 1 commit intocspace-deployment:mainfrom
remillet merged 1 commit intocspace-deployment:mainfrom
Conversation
felder
requested changes
Mar 11, 2026
felder
left a comment
felder
left a comment
There was a problem hiding this comment.
This line seems a bit suspect for ucjeps:
I'm not sure what this is for, but it seems wrong.
Author
|
@felder Thanks for reviewing. That line was copied over from Miriam's code, and I'm guessing they used the BAMPFA host URL as a placeholderbecause there is no UCJEPS host yet: https://github.com/BAM-PFA/glimmer/blob/e559c7e993af9e866620b88e4fd8fb59a41d691e/ucb_extras/ucjeps/config/environments/production.rb#L98 I was going to leave it as-is for now, but I will open a Jira to address it later. I don't know if the UCJEPS or UCBG portals are going to offer login and password reset. BAMPFA does not, but Cinefiles and PAHMA do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira-secure.berkeley.edu/browse/HMP-490