Create User & RD API Endpoints #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
alexy-ok
requested changes
Jan 8, 2026
Member
alexy-ok
left a comment
alexy-ok
left a comment
There was a problem hiding this comment.
Great work, really impressed with how quickly you were able to finish this task.
Just a few small changes that I think could've been caught with some more testing, but overall very satisfied.
server/routes/gcfUser.js
Outdated
| try { | ||
| // Query database | ||
| const data = await db.query(`SELECT * FROM gcf_user`); | ||
| res.status(200).json(keysToCamel(data[0])); |
Member
There was a problem hiding this comment.
fix: For this line, I would remove the [0] as it is returning just one data entry when there are multiple entries
server/routes/gcfUser.js
Outdated
|
|
||
| gcfUserRouter.get("/", async (req, res) => { | ||
| try { | ||
| // Query database |
Comment on lines
8
to
22
| gcfUserRouter.post("/", async (req, res) => { | ||
| try { | ||
| const {id, role, email, first_name, last_name, date_created, created_by} = req.body | ||
| const newGcfUser = await db.query( | ||
| `INSERT INTO gcf_user (id, role, email, first_name, last_name, date_created, created_by) | ||
| VALUES ($1, $2, $3, $4, $5, $6, $7) | ||
| RETURNING *`, | ||
| [id, role, email, first_name, last_name, date_created, created_by] | ||
| ); | ||
| res.status(201).json(keysToCamel(newGcfUser[0])); | ||
| } catch (err) { | ||
| console.error(err); | ||
| res.status(500).send("Internal Server Error"); | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
fix: Remove id as an insertion value
Taking id as an input is currently messing up how ids are generated. They should be auto-incrementing and handled by postgres.
You should be able to remove id as a value that you are inserting. This way the id is generated during insertion not by the backend but by the database.
server/routes/regionalDirector.js
Outdated
|
|
||
| regionalDirectorRouter.get("/", async (req, res) => { | ||
| try { | ||
| // Query database |
server/routes/regionalDirector.js
Outdated
| try { | ||
| // Query database | ||
| const data = await db.query(`SELECT * FROM regional_director`); | ||
| res.status(200).json(keysToCamel(data[0])); |
…r both user and regional director
…ttps://github.com/ctc-uci/gcf into GCF27-Create-User-Regional-Director-API-Endpoints Added revisions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a Express.js file with routes for interacting with the
gcf_usertableCreated a Express.js file with routes for interacting with the
regional_directortableBoth files have:
Added routes to server/src/app.ts
Tested CRUD routes on Postman
Screenshots/Media
Issues
Closes #27
Additional Notes
We deleted some cronjob stuff in the app.ts, as well as the sampleRouter