Only check to continue if version check was run#31
Only check to continue if version check was run#31jfhbrook wants to merge 2 commits intoctorgalson:masterfrom
Conversation
|
Thank you for this one as well. I think this is probably a good idea, but I'd like to clarify the intent. Looking at the code, I think a better way to do it might be to add This would cause the playbook to fail if the shell command returns a nonzero exit code, but I think that's probably the right behaviour. Your thoughts? |
|
Sorry, I missed the notification for this. To be brief, I don't have strong opinions about this. If you have an alternative fix in mind, that's fine by me - feel free to take this as a bug report. |
|
I was able to find the time to give this an update. I tried your suggestion and it worked on my machine! Let me know what you think, I'll try to be more responsive to notifications. |
I got another fix for you. This one skips the "Make sure it even makes sense to continue" check if "Get Vim version" is skipped. This makes it so running the playbook in --check mode succeeds.
Note, this rolls in the change from #29.