Skip to content

Only check to continue if version check was run#31

Open
jfhbrook wants to merge 2 commits intoctorgalson:masterfrom
jfhbrook:check-mode
Open

Only check to continue if version check was run#31
jfhbrook wants to merge 2 commits intoctorgalson:masterfrom
jfhbrook:check-mode

Conversation

@jfhbrook
Copy link

@jfhbrook jfhbrook commented May 22, 2024

I got another fix for you. This one skips the "Make sure it even makes sense to continue" check if "Get Vim version" is skipped. This makes it so running the playbook in --check mode succeeds.

Note, this rolls in the change from #29.

@ctorgalson
Copy link
Owner

Thank you for this one as well. I think this is probably a good idea, but I'd like to clarify the intent.

Looking at the code, I think a better way to do it might be to add check_mode: false to the shell task so that that task always runs (it already uses changed_when: false so as not to report a change on an information-gathering task).

This would cause the playbook to fail if the shell command returns a nonzero exit code, but I think that's probably the right behaviour.

Your thoughts?

@jfhbrook
Copy link
Author

Sorry, I missed the notification for this.

To be brief, I don't have strong opinions about this. If you have an alternative fix in mind, that's fine by me - feel free to take this as a bug report.

@jfhbrook
Copy link
Author

I was able to find the time to give this an update. I tried your suggestion and it worked on my machine! Let me know what you think, I'll try to be more responsive to notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants