Conversation
|
Is there a specific problem this PR is aiming to solve? Also, please don't mix different changes in a single PR. I don't see a reason not to accept the file rearranging, but the API namespacing is unrelated and will probably need some discussion. Also, changing 99 files in one PR is a lot - especially if it's more than one potential change that needs to be checked in each file. |
Yes, this allows additions of backwards incompatible changes without breaking current users. By using a new api version namespace, the two versions will not collide and can be selected by setting the
If you think it would be better to split these, I can open PR with the first commit only and this can be merged after with only the second commit.
I don't think the rest can be split in some reasonable way as it is just adding namespace around everything. |
This PR adds inline namespaces to allow choosing API version. By default, the v1 API is set to inline, thus staying API compatible (however, it breaks ABI).
Additionally, source files inside
srcthat were not part of the mrs_lib shared library were moved toexamplesdirectory.