Added ConfettiBurst to CheckInPopUp feature #102
Conversation
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Amazing job with this! I have one small structural concern and a few nits, but the animation looks awesome.
|
|
||
| val rect = originRectInRoot | ||
|
|
||
| var started by remember(uiState.showing) { mutableStateOf(false) } |
There was a problem hiding this comment.
do we really need this started variable or could we use uiState.showing?
| val g = 1750f | ||
| val t = progress * 1.2f |
There was a problem hiding this comment.
nit: avoid one letter variable names
| ) | ||
|
|
||
| when (particle.shape) { | ||
| //draws circle |
There was a problem hiding this comment.
nit: this comment is not needed
| ) | ||
| } | ||
|
|
||
| //draws rectangle |
There was a problem hiding this comment.
nit: this comment is not needed
| * Renders a confetti burst anchored to a given popup rectangle.(checkinpopup). | ||
| * | ||
| * Reads 'showing' from [ConfettiViewModel]. If false or rect is null, renders nothing. | ||
| * When shown, spawns particles inside the bounds of 'originRectInRoot'. |
There was a problem hiding this comment.
if this is the case, would particleSpawningBounds be a better name?
| val systemUiController: SystemUiController = rememberSystemUiController() | ||
|
|
||
| val checkInUiState = checkInViewModel.collectUiStateValue() | ||
| var confettiBounds by remember { mutableStateOf<Rect?>(null) } |
There was a problem hiding this comment.
do you think we could have the confettiBounds be stored as a part of the repository, so this way the UI doesn't necessarily have to be in this file so it can modify them?
Overview
Sourced and modified from Resell's falling confetti, ConfettiOverlay.
Added a confetti animation that bursts from the Check-In Pop-Up on a successful check-in, using a physic-based burst. The effect is anchored to the pop-up's bounds and is triggered by a ConfettiEvent.
Changes Made
UI
Integration
Testing
Tested manually/visually on emulator
Related PRs or Issues
#99 and cuappdev/resell-android#86
Screenshots
Confetti Burst Demo
confettiBurstDemo.webm