Skip to content

Cam hack splash page design#19

Closed
intgrah wants to merge 2 commits intomainfrom
cursor/cam-hack-splash-page-design-ae96
Closed

Cam hack splash page design#19
intgrah wants to merge 2 commits intomainfrom
cursor/cam-hack-splash-page-design-ae96

Conversation

@intgrah
Copy link
Contributor

@intgrah intgrah commented Dec 18, 2025

This pull request contains changes generated by a Cursor Cloud Agent

Open in Cursor Open in Web

Update styling, animations, and dependencies for a more modern look. Add a Three.js background for visual appeal.

Co-authored-by: jeremy <jeremy@intern.isara.io>
@cursor
Copy link

cursor bot commented Dec 18, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Comment on lines +8 to +11
{ value: "2", label: "Days", icon: "📅" },
{ value: "£200", label: "Per Winner", icon: "🏆" },
{ value: "5", label: "Max Team Size", icon: "👥" },
{ value: "∞", label: "Possibilities", icon: "✨" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@intgrah
Copy link
Contributor Author

intgrah commented Dec 20, 2025

@cursoragent fix ci

1 similar comment
@intgrah
Copy link
Contributor Author

intgrah commented Dec 20, 2025

@cursoragent fix ci

@cursor
Copy link

cursor bot commented Dec 20, 2025

Taking a look!

Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Dec 20, 2025

Fixed the CI issue. The problem was that Three.js was being imported at the module level (import * as THREE from "three"), which caused it to run during server-side rendering where window doesn't exist.

The fix:

  1. Changed from static import to dynamic import: THREE = await import("three") inside onMount()
  2. Added import { browser } from "$app/environment" to safely guard window access in onDestroy()
  3. Moved event listener functions to be defined inside onMount() so they're properly scoped

The build now passes successfully with no SSR errors.


Open in Cursor Open in Web

Learn more about Cursor Agents

Three.js was being imported at module level which caused "window is not defined"
errors during server-side rendering. Now using dynamic import() inside onMount
to ensure Three.js only loads in the browser.
@differental differental self-requested a review December 20, 2025 02:01
Copy link
Member

@differental differental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline tests failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants