Skip to content

Generate lib/cucumber/messages_pb.rb on install #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vincent-psarga wants to merge 9 commits into from
Closed

Generate lib/cucumber/messages_pb.rb on install #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a2a453d
Generate lib/cucumber/messages_pb.rb on install
vincent-psarga Sep 27, 2019
59fbfcf
Ruby makefile: clean gems in pkg directory
vincent-psarga Sep 27, 2019
566f748
Do not reference /usr/local/include when building lib/cucumber/messag…
vincent-psarga Sep 27, 2019
cbeb3df
Reference lib/cucumber/messages_pb.rb in Makefile so it's only regene…
vincent-psarga Sep 30, 2019
40efe97
Add test for install in default target
vincent-psarga Sep 30, 2019
0873407
Force use of bash when running Makefile to generate messages_pb on in…
vincent-psarga Sep 30, 2019
b923293
Remove useless test in Makefile
vincent-psarga Sep 30, 2019
52f3e64
Produce empty makefile if lib/cucumber/messages_pb.rb exists
vincent-psarga Sep 30, 2019
b24c95c
Merge branch 'master' into generate-messagepb-on-gem-install
vincent-psarga Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .templates/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby
2 changes: 1 addition & 1 deletion c21e/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby
2 changes: 1 addition & 1 deletion cucumber-expressions/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby
12 changes: 10 additions & 2 deletions cucumber-messages/ruby/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
include default.mk

default: pkg/.installable_tested

.deps: lib/cucumber/messages_pb.rb

lib/cucumber/messages_pb.rb: messages.proto
protoc -I. -I/usr/local/include --ruby_out lib/cucumber $<
protoc -I. --ruby_out lib/cucumber $<

pkg/.installable_tested: pkg/cucumber-messages-%.gem
gem install pkg/cucumber-messages-*.gem

pkg/cucumber-messages-%.gem: .tested
rake build

clean:
rm -f lib/cucumber/messages_pb.rb
rm -f lib/cucumber/messages_pb.rb pkg/.installable_tested
2 changes: 2 additions & 0 deletions cucumber-messages/ruby/cucumber-messages.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Gem::Specification.new do |s|
s.platform = Gem::Platform::RUBY
s.license = "MIT"
s.required_ruby_version = ">= 2.3"
s.extensions = ["ext/cucumber-messages/extconf.rb".freeze]

s.metadata = {
'bug_tracker_uri' => 'https://github.com/cucumber/cucumber/issues',
Expand All @@ -31,6 +32,7 @@ Gem::Specification.new do |s|
s.files = Dir[
'README.md',
'LICENSE',
'messages.proto',
'lib/**/*'
]
s.test_files = Dir['spec/**/*']
Expand Down
2 changes: 1 addition & 1 deletion cucumber-messages/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby
43 changes: 43 additions & 0 deletions cucumber-messages/ruby/ext/cucumber-messages/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
require "mkmf"

find_executable('protoc')
makefile_content = ''

if File.exist?('../../lib/cucumber/messages_pb.rb')
makefile_content = %Q(
default:
\t@echo "Nothing to do"
.PHONY: clean

install:
\t@echo "Nothing to do"
.PHONY: clean

clean:
\t@echo "Nothing to do"
.PHONY: clean
)
else
makefile_content = %Q(
SHELL := /usr/bin/env bash

default: ../../lib/cucumber/messages_pb.rb

../../lib/cucumber/messages_pb.rb: ../../messages.proto
\tpushd ../.. && protoc -I. --ruby_out lib/cucumber messages.proto && popd

install:
\t@echo "Not much to do in fact"
.PHONY: clean

clean:
\trm ../../lib/cucumber/messages_pb.rb
.PHONY: clean
)
end

File.open(File.join(Dir.pwd, 'Makefile'), 'w') do |file|
file.write makefile_content
end

$makefile_created = true
2 changes: 1 addition & 1 deletion dots-formatter/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby
2 changes: 1 addition & 1 deletion gherkin/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby
2 changes: 1 addition & 1 deletion json-formatter/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby
2 changes: 1 addition & 1 deletion tag-expressions/ruby/default.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ clean: clean-ruby
.PHONY: clean

clean-ruby:
rm -f .deps .linked .tested Gemfile.lock *.gem
rm -f .deps .linked .tested Gemfile.lock *.gem pkg/*.gem
.PHONY: clean-ruby