Fix bug on missing Authorization header#4
Open
magicleon94 wants to merge 1 commit intocuongle:masterfrom
Open
Conversation
I noticed that when the Authorization header is missing (line 21) no error is returned, hence the filter passes and the decorated API (with [JwtAuthentication]) is executed normally. Adding context.ErrorResult assignment should fix the problem. Since I'm not an expert in this field I apologise if my proposition is wrong, and I'd like to learn about what I've done wrong.
|
this is important even for demo |
|
This is a big deal. I'm surprised nobody has picked this up in the highly rated Stackoverflow question which points to it: https://stackoverflow.com/questions/40281050/jwt-authentication-for-asp-net-web-api |
|
I have tried to add this line that you recommended... if (authorization == null || authorization.Scheme != "Bearer")
{
context.ErrorResult = new JwtAuthenticationFailureResult("Missing Authorization Header", request);
return;
}but it makes In my authentication controller where I require [AllowAnonymous] (because I am just logging in), I get: The initial code is working as it should. if (authorization == null || authorization.Scheme != "Bearer")
return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when the Authorization header is missing (line 21) no error is returned, hence the filter passes and the decorated API (with [JwtAuthentication]) is executed normally.
Adding context.ErrorResult assignment should fix the problem.
Since I'm not an expert in this field I apologise if my proposition is wrong, and I'd like to learn about what I've done wrong.