- 
                Notifications
    You must be signed in to change notification settings 
- Fork 36
miscellaneous maintenance (mostly GHA) #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    8b5a766    to
    cc7ca1c      
    Compare
  
    49aedb5    to
    757d177      
    Compare
  
    …ellcheck warnings
…ellcheck warnings cleanup
…ellcheck warnings (./scripts/)
…ellcheck warnings (./scripts/) cont
They are building master curl. Seems overkill to run in each curl PR commit.
This reverts commit 6297e70.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
persist-credentials: false.cancel-in-progress: false.Though perhaps it could be set to
true?to silence pedantic zizmor.
format string to be constant, fix other misc shellcheck warnings.
cito a newlocalworkflow, to not get triggered by curl/curl PRand master commits. These jobs either do not use the curl source repo,
or use its master branch.
To save 5 minutes CI time per curl/curl PR push.
Credits-to: Dan Fandrich
curl/curl@57cc523
pyproject.tomlto install pip packages.To have all of them pinned.
pyproject.tomldefault packages to group to avoid installingthem when unused.
pytest_playwrightto the group.pipupgrades, use the version preinstalled on the host, fordeterminism.
to sync with other curl repos and making it more readily apparent
what they are.
DEFINED ENVchecks.CFLAGS,CXXFLAGSenvs manually. CMake usesthese automatically.
https://cmake.org/cmake/help/latest/envvar/CFLAGS.html
https://cmake.org/cmake/help/latest/envvar/CXXFLAGS.html
w/o sp https://github.com/curl/curl-fuzzer/pull/214/files?w=1