Skip to content

Add files via upload#4

Open
curly60e wants to merge 1 commit intomasterfrom
curly60e-patch-3
Open

Add files via upload#4
curly60e wants to merge 1 commit intomasterfrom
curly60e-patch-3

Conversation

@curly60e
Copy link
Owner

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 25, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 7.38 ⭐ 7.38 ⭐ 0.00
Method Length 99.84 🙂 99.88 🙂 0.04 👎
Working memory 13.33 😞 13.33 😞 0.00
Quality 53.71% 🙂 53.71% 🙂 0.00%
Other metrics Before After Change
Lines 1188 1189 1
Changed files Quality Before Quality After Quality Change
PyBlock.py 53.71% 🙂 53.71% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
PyBlock.py mainmenuREMOTEcontrol 10 🙂 191 😞 24 ⛔ 35.24% 😞 Try splitting into smaller methods. Extract out complex expressions
PyBlock.py APIMenuLOCAL 10 🙂 199 😞 19 ⛔ 37.16% 😞 Try splitting into smaller methods. Extract out complex expressions
PyBlock.py menuD 21 😞 148 😞 14 😞 37.92% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
PyBlock.py platfformsLOCALcontrol 13 🙂 127 😞 28 ⛔ 37.94% 😞 Try splitting into smaller methods. Extract out complex expressions
PyBlock.py lightningnetworkREMOTEcontrol 10 🙂 148 😞 22 ⛔ 40.07% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant