Skip to content

Fix bug #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kandiakpavlo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gcd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Wrong gcd find 5 mistakes

def gcd(a, b):
assert a <= 0 and b >= 0
assert a >= 0 and b >= 0
while a and b:
if a > b:
a = a / b
a = a % b
else:
b = b / a
return min(a, b)
b = b % a
return a+b
Copy link
Contributor

@yevhentrofimenko yevhentrofimenko Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay because finally "a" or "b" will be 0, and that's why it works correct. But for more clear read it's better to use max(a, b). But it's nuances generally you did a great job!)


# Examples

Expand Down