Skip to content

Fix 5 bugs #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maxim-Poleshko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix 5 bugs #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions gcd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
# Wrong gcd find 5 mistakes

def gcd(a, b):
assert a <= 0 and b >= 0
assert a >= 0 and b >= 0 #1st bug: a <= 0
while a and b:
if a > b:
a = a / b
a = a % b #2nd bug: a / b
else:
b = b / a
return min(a, b)
b = b % a #3rd bug: b / a
return max(a, b) #4th bug: min()

# Examples
print(gcd(10, 0)) #5th bug: The programm doesn't have print() function
print(gcd(123, 3))
print(gcd(1000000, 64))
print(gcd(0, 0))

# gcd(10, 0) => 10
# gcd(123, 3) => 3
# gcd(1000000, 64) => 64
# gcd(0, 0) => 0