Avoid potential memory leak #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `spi` references the first element of sibling_pairs, then the decrement will bring `spi` out of the range of `sibling_pairs`, which triggers a memory warning in ASAN. As `spi` is not used before the `break;` statement, it's not clear that it is necessary to decrement its value at all; I wonder whether the line can be deleted entirely? My C++ knowledge is pretty thin, so it's quite possible that I'm overlooking something obvious here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
spireferences the first element of sibling_pairs, then the decrement will bringspiout of the range ofsibling_pairs, which triggers a memory warning in ASAN. (This is causing issues with using 'uspr' from within R.)As
spiis not used before thebreak;statement, it's not clear that it is necessary to decrement its value at all; I wonder whether the line can be deleted entirely?My C++ knowledge is pretty thin, so it's quite possible that I'm overlooking something obvious here.