external volumes update -> remove SanLun endpoints#740
Merged
blewisCycle merged 10 commits intomainfrom Oct 29, 2025
Merged
Conversation
mattoni
previously approved these changes
Oct 27, 2025
Member
mattoni
left a comment
mattoni
left a comment
There was a problem hiding this comment.
Two small cleanup items but LGTM
| @@ -0,0 +1,25 @@ | |||
| # ExternalVolumeAttachmentInstance.yml | |||
| @@ -0,0 +1,14 @@ | |||
| # ExternalVolumeAttachment.yml | |||
mattoni
requested changes
Oct 29, 2025
Comment on lines
+17
to
+34
| oneOf: | ||
| - type: object | ||
| required: [type, details] | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [block] | ||
| details: | ||
| $ref: ./ExternalVolumeAttachmentBlock.yml | ||
|
|
||
| - type: object | ||
| required: [type, details] | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [filesystem] | ||
| details: | ||
| $ref: ./ExternalVolumeAttachmentFilesystem.yml |
Member
There was a problem hiding this comment.
This still should be a discriminated union. You're basing the details on the type.
blewisCycle
changed the title
mattoni
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to discriminated union