-
Notifications
You must be signed in to change notification settings - Fork 32
Update input_recycle.xml #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: source
Are you sure you want to change the base?
Conversation
Adjusted input_recycle.xml tutorial file
|
Thanks for this contribution @OHTAESUK ! Can I ask you to explain the changes in the description. Some of them are obvious:
But some of the buffer sizes and throughput values that are changing are less obvious. I'm not sure if they are necessary for this file to work, or just provide more interesting results? |
|
Dear Professor Wilson @gonuke I have adjusted the comments to provide further details about the change in the input tutorial XML file. |
|
This XML file is the result of individual steps in the tutorial pages that you may also have followed. It would be great to also PR changes to those pages to ensure that the tutorials themselves match this final file. You can find the markdown (technically is ReStructuredText) for these web pages in I see a note that the tutorial intentionally did NOT include a recipe for fresh MOX because it wanted the fuel fab to use the equivalence method to make fresh MOX that was neutronically as similar to fresh UOX as possible. We should discuss whether we want to change this? I'm not sure which of your other changes are related to this? |
gonuke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment about the need for a MOX recipe, and we should discuss how to finalize this PR if you are still interested.
| <val>fresh_uox</val> | ||
| <val>fresh_mox</val> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that this was intentional in this example/tutorial. There is a footnote about this here (https://fuelcycle.org/user/tutorial/mod_rxtr.html).
Since the fuel fabrication facility's model is to blend the input streams to find a reactor physics equivalent to the requested fuel recipe, the purpose of this tutorial is to have that facility produce MOX fuel that is the best possible match to the UOX recipe.
Adjusted input_recycle.xml tutorial file. See the following descriptions:
ㅁ Added missing
fresh_moxrecipe and enabled ALWR reactor to accept MOX fuelㅁ Corrected FuelFab fissile commodity name (
separated-fissile→separated_fissile)ㅁ Increased fissile buffer in Separations (5 t → 50 t) to avoid early stall
ㅁ Removed leftover buffer limit to ensure continuous waste handling
ㅁ Adjusted FuelFab inventories and throughput (fill 94 t, fissile 6 t, throughput 100 t) → to keep MOX fabrication aligned with available Pu and reactor demand (The MOX fuel has Pu content ~ 9%)
ㅁ These numerical changes are not required for file validity, but improve mass-flow stability and yield more interpretable recycle behavior.
Summary of Changes
Design Notes
Check the box if your change does not break any of the following:
Related CEPs and Issues
Fixes #
Associated Developers
Testing and Validation
Reviewers, please refer to the Cyclus Guide for Reviewers.