Open
Conversation
Sosthene00
force-pushed
the
offline_mode
branch
2 times, most recently
from
b5c4efe to
2222106
Compare
Sosthene00
force-pushed
the
offline_mode
branch
3 times, most recently
from
bf061e7 to
caaeb70
Compare
Hardcode a default `DateTime` for all network, 1st June of 2025 for now.
* `getBlockForHash`: needed to retrieve the timestamp of a block * `getBlockHashForHeight`: retrieve the block hash from its height * `getBlockFromTimestamp`: used to get the height of the closest block from a timestamp
Add `toSeconds()` method to `DateTime` and a `toDate()` method to `int`
Birthday becomes a DateTime (stored as unix timestamp) instead of a block height integer. Includes migration logic for existing wallets that still have a block height stored.
* add a ticker box on Seed Phrase Recovery screen * if ticked open birthday picker * if user does'nt provice a birthday set network default
- Set blindbitUrl even on connection failure - Set tip to null when connection fails to properly reflect unavailable state - `reconnect()` check availability before attempting reconnection - Use finally block to ensure notifyListeners is always called
…checks Stop swallowing exceptions in Bip353Resolver.isBip353AddressPresent and DanaAddressService.isDanaUsernameAvailable, letting callers decide how to handle network errors. In RegisterDanaAddressScreen: - Classify registration errors (user error vs network/server error) - Show distinct UI for unverifiable availability (warning icon, orange color) - Add mounted guard in registration catch block
Sosthene00
force-pushed
the
offline_mode
branch
from
caaeb70 to
2c88275
Compare
Owner
|
Is this PR still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to better handle network issues/unreachable external services on wallet creation/restoration. For context current behavior is to fail right away in case we can't reach blindbit.
While the creation/restoration of the wallet itself doesn't need network, we need a call to get the actual birthday of the wallet from the timestamp, and also to check generated dana address availability (and register on the name server).
The idea here is to stop at this step in case we can't do one or both of those operations and fallback to a minimal mode that displays payment code. This way user can still receive a payment right away either from another wallet that is able to scan the qr code, or by sharing it over another channel in case device does have network but external services are down.
[EDIT] Some ideas of further improvements: