Skip to content

Improve search contacts features#287

Open
Sosthene00 wants to merge 3 commits intodevfrom
search_contacts
Open

Improve search contacts features#287
Sosthene00 wants to merge 3 commits intodevfrom
search_contacts

Conversation

@Sosthene00
Copy link
Collaborator

We identified UX and security issues with the search contacts feature:

  • User could search for contacts they registered and other contacts from the name server at the same place without sufficiently clear distinction
  • Add contact form didn't allow searching for unregistered addresses from the name server

That PR cleanly separates the 2 features (searching our contacts vs searching public addresses):

  • ContactsScreen only search for contacts already registered in our device
  • AddContactSheet requests name server and returns contacts we haven't registered yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant