refactor(spdk): replace spend_status with spend_info#292
Closed
Conversation
Owner
Author
|
note: not yet tested |
cygnet3
force-pushed
the
replace_spend_status_info
branch
3 times, most recently
from
9f43f7e to
d0d2c53
Compare
Owner
Author
|
While testing this I noticed that we are inconsistent with how we currently store data for the Spent and Mined types. The SpendStatus is using consensus-encoding rather than the encoding we use in other places (which uses to more common encoding). This PR makes the encoding consistent with the other encodings, but maybe we don't want to do this now, and instead switch the encoding once we move the data from flutter storage to sqlite. |
Collaborator
|
Just for the record, this is a subset of the changes in the #272 branch |
cygnet3
force-pushed
the
replace_spend_status_info
branch
from
d0d2c53 to
d8ef30f
Compare
Sosthene00
force-pushed
the
replace_spend_status_info
branch
2 times, most recently
from
71d67d9 to
18a922b
Compare
Replace spend_status with spend_info on the spdk side. This old approach dropped the spend_txid when the spend_status switched from 'spent' to 'mined'. Note: this PR does not solve the above issue, it only adds support for a new struct type spend_info which technically allow for more data.
Sosthene00
force-pushed
the
replace_spend_status_info
branch
from
18a922b to
5bfbf07
Compare
Collaborator
|
This has been superseded by #310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace spend_status with spend_info on the spdk side. This old approach dropped the spend_txid when the spend_status switched from 'spent' to 'mined'.
Note: this PR does not solve the above issue, it only adds support for a new struct type spend_info which technically allow for more data.