Draft
Conversation
Remove Hrn dnssec partial implementation (HrnPsbtExt should not be provided by spdk) Migrate to DleqProof type
Remove helper module providing SimpleWallet, Utxo, TranscationConfig, VirtualWallet
Switch to rust-dleq native implementation by default Add documentation for switching between native and standalone crypto for dleq
…e that constructor computes the labeled address correctly and stores in SP_V0_INFO
Add PSBT state check Add is_input_eligible
… PSBT_IN_SP_SPEND_BIP32_DERIVATION simplify ecdh share coverage
…d_secrets helper in bip352.rs for finalize_inputs and validate_output_scripts Also validate full ECDH coverage across all inputs before processing outputs
requires pairs() from rust-psbt
macgyver13
force-pushed
the
bip375-updates-rev2
branch
from
cc587cd to
762b897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great start on porting to spdk. I think this project is a great place for the silent payments psbt to land.
Migrate additional psbt extension traits to extensions (unifies imports from same rust-psbt version through spdk
Use DleqProof type from rust-psbt
Expand psbt taproot handling
Remove helper module providing SimpleWallet, Utxo, TransactionConfig, VirtualWallet