Fix: Restrict search indexing to active apps only#117
Open
qzMalekuz wants to merge 2 commits intocytoscape:masterfrom
Open
Fix: Restrict search indexing to active apps only#117qzMalekuz wants to merge 2 commits intocytoscape:masterfrom
qzMalekuz wants to merge 2 commits intocytoscape:masterfrom
Conversation
Search was indexing inactive apps while the detail view requires active=True. This caused search results to link to 404 pages. Override index_queryset() in AppIndex to ensure only active apps are indexed.
Author
|
I have tested this locally and everything works as expected. Please let me know if any changes are needed. |
Contributor
|
Could you add a unit test for this to |
Author
|
Added a regression test to ensure AppIndex.index_queryset() only indexes active apps. All tests pass locally using make test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that only active apps are indexed by Haystack by implementing index_queryset() in AppIndex.
Previously, inactive apps could appear in search results.
This change filters the index to App.objects.filter(active=True).
Related Issue - #114