Skip to content

Take in account cases when exceptions on fail must be silenced #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
query-string wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Take in account cases when exceptions on fail must be silenced #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/pin_up/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ class Base
# env: The environment you want to use.
# Leave blank for live and pass :test for test
# An error is raised if an invalid env is passed in.
def initialize(key = '', env = :live, timeout = 1800)
# raise_on_fail: Be able to disable execptions on fail
def initialize(key = '', env = :live, timeout = 1800, raise_on_fail = true)
@key = key
env = env.to_sym
@@auth = { username: @key, password: '' }
@@timeout = timeout
@@raise_on_fail = raise_on_fail
@@base_url = if env == :live
'https://api.pin.net.au/1/'
elsif env == :test
Expand Down Expand Up @@ -45,7 +47,7 @@ def self.make_request(method, args)
# Builds a response of a single object
def self.build_response(response)
if response.code >= 400
Pin::PinError.handle_error(response.code, response.parsed_response)
@@raise_on_fail ? Pin::PinError.handle_error(response.code, response.parsed_response) : response.parsed_response
elsif response.code == 204
response
else
Expand Down