Skip to content

Modernise build tooling and configuration#15

Open
MarkBird wants to merge 1 commit intomasterfrom
modernise-build-tooling
Open

Modernise build tooling and configuration#15
MarkBird wants to merge 1 commit intomasterfrom
modernise-build-tooling

Conversation

@MarkBird
Copy link
Copy Markdown

Transition the project from the old-school setup.py style to the more modern pyproject.toml approach.

@dabapps-robot dabapps-robot self-requested a review February 26, 2026 15:14
Copy link
Copy Markdown

@dabapps-robot dabapps-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR — this is a solid modernization and a clear improvement overall. Moving to pyproject.toml, using python -m build, and switching to trusted publishing via pypa/gh-action-pypi-publish all look like the right direction.

A couple of things worth double-checking before merge:

  1. simple_robots.__version__ was removed

    • Previously this was part of the package surface in __init__.py.
    • If any consumers (or your own docs/tests) reference simple_robots.__version__, this is a breaking change.
    • Might be worth keeping a compatibility __version__ export (or explicitly calling out its removal in release notes).
  2. Python support floor is now >=3.10

    • This is fine if intentional, but it is a meaningful support-policy change versus the previous workflow using 3.8.
    • Worth confirming docs/classifiers/changelog are aligned so users aren’t surprised.

If those two points are intentional and documented, this looks ready to merge from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants