Merged
Conversation
…lling fallback logic
Sort imports Make testSelectorsAreComplete a view function Use the interfaces directly to assert the diamond supports them
Refactored internal diamond cut functions to accept DiamondStorage as a parameter and replaced private helper functions with internal ones for better code reuse. Added new calldata-based diamond cut functions to support FacetCut[] calldata and bytes calldata, improving gas efficiency and flexibility. Enhanced initialization error handling and updated selector/facet position helpers for consistency.
Simplifies imports and restructures the Diamond contract to use internal delegate and implementation functions. The fallback and receive functions are now virtual, and diamond cut logic is encapsulated in an internal method. The contract initialization is updated to accept facet cuts, init address, and calldata directly, improving modularity and extensibility.
Replaces the call to LibDiamond._diamondCut with LibDiamond._diamondCutCalldata in DiamondCutFacet. This change likely reflects an update in the library's API or a need to use calldata-specific logic.
Updated foundry.toml to set optimizer_runs to 999,999 and explicitly disabled via_ir. These changes may improve contract optimization and control IR compilation behavior.
Updates the GitHub Actions workflow to install the nightly version of Foundry using the foundry-toolchain action. Ensures tests run against the latest nightly build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.