Conversation
Signed-off-by: kpenfound <kyle@dagger.io>
| "engineVersion": "v0.20.3", | ||
| "sdk": { | ||
| "source": "github.com/vito/dang/dagger-sdk@352d057a4d4c4d77612104f842671b512495ef30" | ||
| "source": "dang" |
There was a problem hiding this comment.
This part's not quite ready for prime time - needs dagger/dagger#12830 first otherwise no checks are loaded (which is why this PR is ✔️)
Could be worth merging anyway and letting it magically un-break in the future when we ship a new engine, if this is all WIP, but yeah
There was a problem hiding this comment.
Just realized this is "sdk": { "source": "dang" } instead of "sdk": "dang". Not sure how I messed that up because I did it at the same time as eslint and prettier. Since I merged the PR for eslint and prettier, would that mean the checks for those on the latest commit would be broken?
There was a problem hiding this comment.
"sdk": { "source": "dang" } is technically correct and I think what dagger develop will spit back out
Since I merged the PR for eslint and prettier, would that mean the checks for those on the latest commit would be broken?
Yeah - the bug is that the native dang SDK doesn't support detecting @check, so check -l etc. will just be empty
There was a problem hiding this comment.
Ah, I probably ran develop on this one before pushing, that makes sense
2 participants
No description provided.