Angular 19 + deprecate response mapper #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perator - use rxjs map immediately before this opereator instead
vala84no
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Angular 19 and deprecate the response mapper argument for
httpRequestStates()in favour of using RxJs's native map beforehand.The only two Angular APIs we use directly are
HttpErrorResponseandHttpResponsewhich have not changed in Angular 19, so we can add Angular 19 support in peerDependencies immediately before we upgrade this repo itself to Angular 19 (for which, we're waiting on nx to release support for it - maybe we should just not bother using nx in this repo?).