Fix: reject implicit data types in data_declaration #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #118.
Summary
This change ensures that implicit data types in
data_declarationare rejected unless thevarkeyword is explicitly used.This aligns the parser behavior with the SystemVerilog standard and prevents ambiguous parsing inside procedural blocks.
Changes
verifylogic to reject implicit data types indata_declaration_variablewhenvaris not used.Notes on Spec Tests
Some spec tests were previously validating the parsing of procedural assignments as
module_items.However, such statements are illegal at the module scope according to the SystemVerilog LRM.
This incorrect behavior was caused by treating identifier-leading procedural assignments as implicit declarations.
This PR corrects that behavior, and the affected spec tests have been updated accordingly.