Open
Conversation
…isten for connections (or if not provided :: or 0.0.0.0)
Collaborator
|
👍 |
Collaborator
|
@nick2170 I'll leave it for you to hit merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All I have done here is update to version 2.0.x of the Socket.io libraries (server and client). I've run the unit tests and they pass, and have had a go with the server and it works okay.
Just issuing a PR in case you want to have a quick look with your environments (Nick, I believe you had some teachers using buzzer with their students) to make sure nothing breaks in the wild.
Otherwise if you are happy, I'll commit.
Ta.
D.