Fix: SSO checks report 'not configured' instead of 'NOT logged in' when SSO type is absent#82
Open
bigdoodr wants to merge 1 commit intodan-snelson:bugfix/81from
Open
Fix: SSO checks report 'not configured' instead of 'NOT logged in' when SSO type is absent#82bigdoodr wants to merge 1 commit intodan-snelson:bugfix/81from
bigdoodr wants to merge 1 commit intodan-snelson:bugfix/81from
Conversation
Added a file-existence check alongside xmllint, so a missing or empty plist cleanly falls through to "Kerberos SSO not configured" rather than "NOT logged in"
Changed the Kerberos fallback message from "${loggedInUser} NOT logged in" to "Kerberos SSO not configured" for the invalid-plist case
Changed the Platform SSOe fallback from "${loggedInUser} NOT logged in" to "Platform SSO not configured"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the companion case to #81 where SSO checks display "NOT logged in" results when a particular SSO type isn't configured on the machine.
Changes:
Tested against:
first.lastNOT logged in, now shows Kerberos SSO not configurednetIDNOT logged in, now shows Platform SSO not configured