Disable open-access-only external services for embargoed dandisets#2654
Open
Disable open-access-only external services for embargoed dandisets#2654
Conversation
Co-authored-by: yarikoptic <39889+yarikoptic@users.noreply.github.com>
Co-authored-by: yarikoptic <39889+yarikoptic@users.noreply.github.com>
…ckage-lock Co-authored-by: yarikoptic <39889+yarikoptic@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Disable external services for embargoed dandisets
Disable open-access-only external services for embargoed dandisets
Nov 26, 2025
Member
|
there are frontend tests under e2e/tests/fileBrowserPage.spec.ts, but I do not see them testing anything about embargoed dandisets ATM unfortunately, so it might be a bit too much to establish testing for emabrgoed dandisets in them. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


External services in the "Open With" menu were enabled for embargoed dandisets despite being unable to access embargoed data, resulting in errors when users clicked them.
Changes
Service configuration (
web/src/utils/externalServices.ts)openaccessOnly?: booleanattribute toExternalServiceinterface (defaults totrue)openaccessOnly: false(supports embargoed access via API key)getExternalServices()to returndisabled: booleanflag based on embargo statusUI (
web/src/views/FileBrowserView/FileBrowser.vue)Behavior
For embargoed dandisets:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.