Skip to content

EMBER named it sandbox already not staging#1590

Merged
yarikoptic merged 2 commits intomasterfrom
ember-sandbox
Mar 7, 2025
Merged

EMBER named it sandbox already not staging#1590
yarikoptic merged 2 commits intomasterfrom
ember-sandbox

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

Although there is still no https://dandi-sandbox.emberarchive.org/ yet -- better than it is now and I need release, so I will release if no test fails

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "black dandi/tests/test_dandiarchive.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'dandi-staging\\.' 'dandi-sandbox.'; git-sedi ember-staging ember-sandbox",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Mar 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (52017d7) to head (0351bce).
Report is 108 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
+ Coverage   88.54%   88.64%   +0.09%     
==========================================
  Files          78       78              
  Lines       10872    10872              
==========================================
+ Hits         9627     9637      +10     
+ Misses       1245     1235      -10     
Flag Coverage Δ
unittests 88.64% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic
Copy link
Copy Markdown
Member Author

3.9 fail is spurious and/or unrelated:

_ test_parse_api_url[https://gui.dandiarchive.org/#/dandiset/000001-parsed_url0] _

@yarikoptic yarikoptic merged commit c2849d3 into master Mar 7, 2025
31 of 32 checks passed
@yarikoptic yarikoptic deleted the ember-sandbox branch March 7, 2025 01:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2025

🚀 PR was released in 0.67.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged release Create a release when this pr is merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant