Skip to content

Enh service script publish version doi#1612

Merged
yarikoptic merged 7 commits intodandi:masterfrom
asmacdo:enh-service-script-publish-version-doi
Apr 22, 2025
Merged

Enh service script publish version doi#1612
yarikoptic merged 7 commits intodandi:masterfrom
asmacdo:enh-service-script-publish-version-doi

Conversation

@asmacdo
Copy link
Copy Markdown
Member

@asmacdo asmacdo commented Apr 16, 2025

Fixes dandi/dandi-archive#1953

Demonstration procedure:

  • spin up DANDI-archive without DOI configuration (and so will skip creation of real DOI, but will still inject the DOI into the Version)
  • create and publish a DANDI set
  • set up DOI configuration in DANDI CLI using the DJANGO_DANDI_DOI* variables from DANDI-archive
  • use the command with the published DANDI set/version

TODOs

  • fix typing for CI

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 21.27660% with 37 lines in your changes missing coverage. Please review.

Project coverage is 88.34%. Comparing base (88c3275) to head (d77449b).
Report is 96 commits behind head on master.

Files with missing lines Patch % Lines
dandi/cli/cmd_service_scripts.py 21.27% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
- Coverage   88.58%   88.34%   -0.24%     
==========================================
  Files          78       78              
  Lines       10937    10977      +40     
==========================================
+ Hits         9688     9698      +10     
- Misses       1249     1279      +30     
Flag Coverage Δ
unittests 88.34% <21.27%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic marked this pull request as ready for review April 21, 2025 18:07
@asmacdo asmacdo added the minor Increment the minor version when merged label Apr 21, 2025
@yarikoptic
Copy link
Copy Markdown
Member

windows fails are unrelated -- decided to fail for all those (seems) in

_ test_parse_api_url[https://gui.dandiarchive.org/#/dandiset/000001-parsed_url0] _
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\connectionpool.py:787: in urlopen
    response = self._make_request(
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\connectionpool.py:488: in _make_request
    raise new_e
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\connectionpool.py:464: in _make_request
    self._validate_conn(conn)
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\connectionpool.py:1093: in _validate_conn
    conn.connect()
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\connection.py:741: in connect
    sock_and_verified = _ssl_wrap_socket_and_match_hostname(
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\connection.py:920: in _ssl_wrap_socket_and_match_hostname
    ssl_sock = ssl_wrap_socket(
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\util\ssl_.py:480: in ssl_wrap_socket
    ssl_sock = _ssl_wrap_socket_impl(sock, context, tls_in_tls, server_hostname)
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\site-packages\urllib3\util\ssl_.py:524: in _ssl_wrap_socket_impl
    return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\ssl.py:455: in wrap_socket
    return self.sslsocket_class._create(
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\ssl.py:1076: in _create
    self.do_handshake()
C:\hostedtoolcache\windows\Python\3.13.2\x64\Lib\ssl.py:1372: in do_handshake
    self._sslobj.do_handshake()
E   ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host

but different URIs... Let's consider to be done with this script for now -- tested as "it works"

@yarikoptic yarikoptic merged commit 414107d into dandi:master Apr 22, 2025
23 of 28 checks passed
@github-actions
Copy link
Copy Markdown

🚀 PR was released in 0.68.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do try to (re)mint DOIs for prior failed to be minted but released dandisets

3 participants