Remove obsolete (without effect) piece of code in bids.py for validation#1615
Merged
yarikoptic merged 1 commit intomasterfrom Apr 17, 2025
Merged
Remove obsolete (without effect) piece of code in bids.py for validation#1615yarikoptic merged 1 commit intomasterfrom
yarikoptic merged 1 commit intomasterfrom
Conversation
we already demand bidsschematools ~1.0 so if we are to follow the comment -- we should be fine. But also -- bids_paths seems to be not used (since 45209e2 awhile back) so it was dead code to start with.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
+ Coverage 88.58% 88.64% +0.06%
==========================================
Files 78 78
Lines 10937 10930 -7
==========================================
+ Hits 9688 9689 +1
+ Misses 1249 1241 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
candleindark
approved these changes
Apr 17, 2025
Member
candleindark
left a comment
There was a problem hiding this comment.
I don't see any affect from this piece of code either. Possibly, its use has been long removed (don't see to need to investigate more now).
Member
Author
|
Fail is unrelated |
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we already demand bidsschematools ~1.0 so if we are to follow the comment -- we should be fine. But also -- bids_paths seems to be not used (since 45209e2 awhile back) so it was dead code to start with.