Skip to content

Remove obsolete (without effect) piece of code in bids.py for validation#1615

Merged
yarikoptic merged 1 commit intomasterfrom
rf-bids-validation
Apr 17, 2025
Merged

Remove obsolete (without effect) piece of code in bids.py for validation#1615
yarikoptic merged 1 commit intomasterfrom
rf-bids-validation

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

we already demand bidsschematools ~1.0 so if we are to follow the comment -- we should be fine. But also -- bids_paths seems to be not used (since 45209e2 awhile back) so it was dead code to start with.

we already demand bidsschematools ~1.0 so if we are to follow the comment -- we
should be fine.  But also -- bids_paths seems to be not used (since
45209e2 awhile back) so it was dead code
to start with.
@yarikoptic yarikoptic added the internal Changes only affect the internal API label Apr 17, 2025
@yarikoptic yarikoptic requested a review from candleindark April 17, 2025 14:42
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (88c3275) to head (2e6e76c).
Report is 96 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
+ Coverage   88.58%   88.64%   +0.06%     
==========================================
  Files          78       78              
  Lines       10937    10930       -7     
==========================================
+ Hits         9688     9689       +1     
+ Misses       1249     1241       -8     
Flag Coverage Δ
unittests 88.64% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@candleindark candleindark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any affect from this piece of code either. Possibly, its use has been long removed (don't see to need to investigate more now).

@yarikoptic
Copy link
Copy Markdown
Member Author

Fail is unrelated

test_parse_api_url[https://gui.dandiarchive.org/#/dandiset/000001-parsed_url0] _
/opt/hostedtoolcache/Python/3.12.10/x64/lib/python3.12/site-packages/urllib3/connectionpool.py:787: in urlopen
    response = self._make_request(
/opt/hostedtoolcache/Python/3.12.10/x64/lib/python3.12/site-packages/urllib3/connectionpool.py:488: in _make_request
    raise new_e
/opt/hostedtoolcache/Python/3.12.10/x64/lib/python3.12/site-packages/urllib3/connectionpool.py:464: in _make_request
    self._validate_conn(conn)

@yarikoptic yarikoptic merged commit 6518334 into master Apr 17, 2025
30 of 31 checks passed
@yarikoptic yarikoptic deleted the rf-bids-validation branch April 17, 2025 17:11
@github-actions
Copy link
Copy Markdown

🚀 PR was released in 0.68.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes only affect the internal API released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants