Skip to content

Deduplicate validation results yield from validate.validate() #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yarikoptic merged 1 commit into from
Apr 25, 2025
Merged

Deduplicate validation results yield from validate.validate() #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions dandi/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,16 @@ def validate(
path, errors
errors for a path
"""
# Archive of unique `ValidationResult` objects obtained through
# `DandiFile.get_validation_errors()`
# Note: This is needed to hold on to the unique `ValidationResult` objects
# so that they don't get garbage collected, ensuring that the same ID in
# `df_result_ids` is always associated with the same object.
df_results: list[ValidationResult] = []

# The ids of the objects in `df_results` obtain through the `id()` built-in function
df_result_ids: set[int] = set()

for p in paths:
p = os.path.abspath(p)
dandiset_path = find_parent_directory_containing(dandiset_metadata_file, p)
Expand All @@ -171,6 +181,11 @@ def validate(
for df in find_dandi_files(
p, dandiset_path=dandiset_path, allow_all=allow_any_path
):
yield from df.get_validation_errors(
for r in df.get_validation_errors(
schema_version=schema_version, devel_debug=devel_debug
)
):
r_id = id(r)
if r_id not in df_result_ids:
df_results.append(r)
df_result_ids.add(r_id)
yield r
Loading