Temp: remove reference to .ngff and .zarr for is_dir in move function#1620
Closed
aaronkanzer wants to merge 2 commits intodandi:masterfrom
Closed
Temp: remove reference to .ngff and .zarr for is_dir in move function#1620aaronkanzer wants to merge 2 commits intodandi:masterfrom
aaronkanzer wants to merge 2 commits intodandi:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
+ Coverage 88.28% 88.41% +0.12%
==========================================
Files 78 78
Lines 11038 11038
==========================================
+ Hits 9745 9759 +14
+ Misses 1293 1279 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yarikoptic @satra
Pushing to a PR to have a remote branch to test why exactly this logic is necessary -- seems to be a slight blocker