Improve follow_redirect() so that it has a singular checkpoint for limiting number of attempts and clearer logic

[candleindark]

This PR is a follow up to #1632. It further improves follow_redirect() by implementing more clear logic. Particularly it uses singular a checkpoint for limiting number of attempts . Please see the commit message for more details.

[Copilot]

Pull Request Overview

This PR refactors the follow_redirect() function to improve clarity in its retry logic and error handling.

• Updates exception handling to raise FailedToConnectError with more detailed messages.
• Adjusts test expectations in dandi/tests/test_dandiarchive.py to match the new error types and messages.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
dandi/tests/test_dandiarchive.py	Updates the expected exception and regex for the FailedToConnectError.
dandi/dandiarchive.py	Refines the retry logic and error messaging in follow_redirect().

Comments suppressed due to low confidence (2)

dandi/dandiarchive.py:897

• [nitpick] Consider renaming the loop variable 'i' to a more descriptive name like 'attempt' to improve code clarity.

for i in range(retries):

dandi/tests/test_dandiarchive.py:446

• Ensure that the regex pattern in the test fully captures both variants of the error message produced in follow_redirect(), considering the additional status code details now included.

with pytest.raises(FailedToConnectError, match=r"failed with \d+ attempts"):

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.84%. Comparing base (6d30523) to head (22910d8).
⚠️ Report is 108 commits behind head on master.

Files with missing lines	Patch %	Lines
dandi/dandiarchive.py	75.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
+ Coverage   88.77%   88.84%   +0.07%     
==========================================
  Files          82       82              
  Lines       11434    11439       +5     
==========================================
+ Hits        10150    10163      +13     
+ Misses       1284     1276       -8     

Flag	Coverage Δ
unittests	88.84% <76.92%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[candleindark]

@yarikoptic Should I add a patch label to this PR. It is mostly refactoring.

[yarikoptic]

thanks, will review later. If you could make title more descriptive (as to why/what reorganization brings) - would be good since it would be included in the changelog at the end.