Skip to content

Unrestrict dandischema version#1637

Merged
yarikoptic merged 1 commit intodandi:masterfrom
candleindark:unrestrict-dandischema
Jun 4, 2025
Merged

Unrestrict dandischema version#1637
yarikoptic merged 1 commit intodandi:masterfrom
candleindark:unrestrict-dandischema

Conversation

@candleindark
Copy link
Copy Markdown
Member

@candleindark candleindark commented May 23, 2025

This is to undo a change brought by #1630 Now that dandiarchive is using the new JSON schema.

This PR closes #1635.

This is to undo a change brought by
https://github.com/dandi/dandi-cli/pull/1630/files
Now that dandiarchive is using the new
JSON schema
@candleindark candleindark requested a review from yarikoptic May 23, 2025 17:29
@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.84%. Comparing base (6d30523) to head (5b813d4).
⚠️ Report is 106 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
+ Coverage   88.77%   88.84%   +0.06%     
==========================================
  Files          82       82              
  Lines       11434    11434              
==========================================
+ Hits        10150    10158       +8     
+ Misses       1284     1276       -8     
Flag Coverage Δ
unittests 88.84% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h-mayorquin
Copy link
Copy Markdown

Should close #1635

@yarikoptic
Copy link
Copy Markdown
Member

ATM it is only the staging instance of DANDI archive https://gui-staging.dandiarchive.org/, and current version of client should work with both since there is "upgrade" path for metadata to go from older to newer one on the server thus even staging with newer dandischema would accept older version. But the deployed version would not got backwards, so we need to wait for main deployments to upgrade first before we allow for new version of dandischema in dandi-cli

@yarikoptic
Copy link
Copy Markdown
Member

We just released 0.11.0 of dandi-archive which gave us schema 0.6.10 so should be ok to merge/release

image

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Jun 4, 2025
@yarikoptic yarikoptic merged commit 59bb266 into dandi:master Jun 4, 2025
29 of 30 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 4, 2025

🚀 PR was released in 0.69.3 🚀

@candleindark candleindark deleted the unrestrict-dandischema branch June 4, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged release Create a release when this pr is merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New release to unwind schema pin?

3 participants