Skip to content

Workaround: catch AttributeError while formatting exception#1638

Merged
yarikoptic merged 1 commit intomasterfrom
bf-workaround-exceptiongroup
May 25, 2025
Merged

Workaround: catch AttributeError while formatting exception#1638
yarikoptic merged 1 commit intomasterfrom
bf-workaround-exceptiongroup

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

I remembered doing this and then found patch within dandi-feedstock , but never submitted here as a fix, but we ran into it within dandischema recently (thus attn to @candleindark )

@yarikoptic yarikoptic added the patch Increment the patch version when merged label May 23, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.83%. Comparing base (5555a76) to head (8550449).
⚠️ Report is 161 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
+ Coverage   88.52%   88.83%   +0.31%     
==========================================
  Files          78       82       +4     
  Lines       10872    11438     +566     
==========================================
+ Hits         9624    10161     +537     
- Misses       1248     1277      +29     
Flag Coverage Δ
unittests 88.83% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic merged commit 587c073 into master May 25, 2025
31 checks passed
@yarikoptic yarikoptic deleted the bf-workaround-exceptiongroup branch May 25, 2025 16:04
@github-actions
Copy link
Copy Markdown

🚀 PR was released in 0.69.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant