-
Notifications
You must be signed in to change notification settings - Fork 15
Vendor-Configurable Metadata Models #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
8b66164
Devendorize: Replace DANDI specific identifier with more generic regexes
yarikoptic 2388b15
Allow for vendorization of the "dandi:" namespace
yarikoptic 697731a
Fix regex for DOI
yarikoptic 704ba4a
feat: support vendorization through config
candleindark 75f146f
test: update tests for changes in support of vendorization
candleindark 266254c
rf: rename `test_dantimeta_1()` to `test_dandimeta_1()`
candleindark 8c3a3e7
fix: add end of string anchor to `DANDI_DOI_PATTERN`
candleindark 8ceed31
feat: define `PublishedDandiset.doi` on condition
candleindark 2cd0116
test: adjust tests for conditional definition of `PublishedDandiset.doi`
candleindark 1f9ab2f
test: provide DANDI and EMBER datacite login accordingly
candleindark 9ee60bd
rf: set default shell to bash in `test.yml`
candleindark 0129396
test: skip tests that depends on the setting of `DOI_PREFIX` conditio…
candleindark 312d45d
fix: add end of string anchor to `DANDI_PUBID_PATTERN `
candleindark 917da9d
test: update skip condition on datacite related tests
candleindark 0a0d94d
test: remove datacite auth info requirement for `test_datacite_relate…
candleindark 794d9eb
rf: define and use `skipif_no_doi_prefix` decorator
candleindark 69a21f9
rf: rename support function for test
candleindark fe5aae1
test: condition some tests on existence of test metadata
candleindark 27a5b8f
style: simplify string expression
candleindark ea54db7
test: vendorize CI environment for dandi-cli tests
candleindark 01d86aa
rf: rename `conf.CONFIG` to `conf.INSTANCE_CONFIG`
candleindark b2cb8ad
feat: let `Config` have `doi_prefix` field instead of `datacite_doi_i…
candleindark 98aee1d
feat: define mechanism to reset instance config
candleindark c9b53e6
feat: remove the importing of `dandischema.metadata` in `dandischema`
candleindark 36c88be
feat: replace use of `conf.INSTANCE_CONFIG` with `get_instance_config()`
candleindark 169449a
test: adjust `skipif_no_datacite_auth`
candleindark 3b3ff10
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a125b74
test: add test for `get_instance_config`
candleindark 11cf3db
test: add tests for `set_instance_config`
candleindark d8fa7dd
Merge pull request #306 from dandi/devendorize-config-reset
yarikoptic f2ecf9d
feat: allow `Config` or `dict` as input to `set_instance_config()`
candleindark 2b7d935
Merge branch 'master' into devendorize
candleindark 13a919f
test: update testing of `set_instance_config`
candleindark 3576941
test: update testing of `set_instance_config`
candleindark c7bb614
feat: remove `id_pattern` property from `dandischema.conf.Config`
candleindark e712e4d
feat: remove `doi_prefix_pattern` property from `dandischema.conf.Con…
candleindark 276844b
test: delay import of `dandischema.conf` in `test_conf.py`
candleindark c5f6327
test: add `TestConfig`
candleindark cf0293e
feat: add `licenses` field to `dandischema.conf.Config`
candleindark 13b5364
feat: make `dandischema.models.LicenseType` instance specific
candleindark 94accb8
test: update `TestSetInstanceConfig`
candleindark 5bcdb38
test: update `test_types()`
candleindark 46fba4b
test: add tests for instantiating `dandischema.conf.Config` with valu…
candleindark f9bb9be
perf: simplify json file storing SPDX license IDs
candleindark 06a3638
feat: provide script for constructing the SPDX license ID list
candleindark 1813632
Merge branch 'master' into vendorize-licenses
candleindark c1e1f2b
doc: improve doc string for `dandischema.models.LicenseType`
candleindark 04ac72a
Add timeout to GET request in SPDX License fetching helper script
candleindark 739edda
style: replace `importlib.resources.abc.Traversable.joinpath` uses
candleindark 99f7722
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4d35d09
fix: avoid hardcoding package name in `importlib.resources.files()` use
candleindark 03617c6
style: mark internal funcs in `conf.py` private
candleindark 4519e35
Merge branch 'master' into devendorize
candleindark 4483d56
rf: define default instance name in a const
candleindark e40c21d
rf: make unvendored ID pattern non-private
candleindark d94ada9
feat: relex pattern for prefix of identifier when appropriate
candleindark 09b470b
test: update tests per relaxed ID pattern
candleindark 3d57ce0
rf: remove private naming of unvendored DOI prefix pattern
candleindark 1b95c84
feat: relax DOI pattern when DOI prefix is not provided in Config
candleindark 1570932
test: update tests for relax DOI pattern when appropriate
candleindark 72b5257
style: simplify regex expression
candleindark 4f04034
Merge pull request #312 from dandi/vendorize-licenses
yarikoptic b78da9e
Merge pull request #317 from dandi/relax-on-default
yarikoptic 838bcf6
feat: provide environment variable aliases for setting instance config
candleindark 23b404d
test: update tests for `dandischema.conf.py`
candleindark 964d540
Merge pull request #322 from dandi/env-var-alias
candleindark bbd9f3e
Merge branch 'master' into devendorize
candleindark 24340c1
ci: remove `DANDI_INSTANCE_NAME` and `DANDI_DOI_PREFIX` in `Test agai…
candleindark ffe0640
feat: make DataCite metadata generation vendor dependent
yarikoptic a9e1293
feat: add `instance_identifier` field to `Config`
candleindark 4c0ed42
feat: set default of instance identifier to `None`
candleindark 9e9881a
chore: remove unused import of `requests`
candleindark e0478e2
test: update tests related to DateCite metadata generation
candleindark 16bb639
test: update CI test workflow
candleindark b07e839
test: add test for `instance_identifier`
candleindark 4efc64c
feat: condition the value of instance identifier
candleindark a2280e2
test: update tests for the introduction of instance identifier field
candleindark 7ef784f
Merge pull request #323 from dandi/publisher-tuneup-in-datacite
candleindark 0ecbfaa
feat: provide publisher identifier only when available in DataCite me…
candleindark 8f1da33
feat: add `instance_url` field to `dandischema.conf.Config`
candleindark e9c2645
Merge pull request #328 from dandi/devendorize-instance-url
candleindark 146bbd5
Merge branch 'master' into devendorize
candleindark 414718b
Use generic programming check for having instance_identifier set
yarikoptic 2cd1a45
Merge pull request #326 from dandi/handle-none-instance-identifier
candleindark efdbe88
Merge branch 'master' into devendorize
candleindark 69a0e82
doc: add information to customize metadata models with vendor informa…
candleindark f9979a2
Merge pull request #330 from dandi/devendorize-readme
yarikoptic f1d9dc7
test: remove use of `unittest.mock.ANY`
candleindark fdddc69
Merge pull request #335 from dandi/fix-mypy-errs
yarikoptic 6858916
feat: allow `Config` to be initialized with field names
candleindark 22bf029
test: update tests so that field names are used to initialize Config
candleindark f32125a
test: add `"instance_url"` key to config dict for testing
candleindark 715a383
test: test initializing `dandischema.conf.Config` kwargs
candleindark 8fe9701
test: test init `dandischema.conf.Config` by field names through dote…
candleindark 7eafc38
test: test round trip of `dandischema.conf.Config`
candleindark 5406628
Merge pull request #336 from dandi/devendorize-init-config-with-field…
yarikoptic 24f800e
Merge branch 'master' into devendorize
candleindark 33ac781
Merge branch 'master' into devendorize
candleindark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| __all__ = ["__version__", "migrate", "validate"] | ||
| __all__ = ["__version__"] | ||
|
|
||
| from ._version import __version__ | ||
| from .metadata import migrate, validate |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.