Replace discriminated unions with simple unions in models#385
Open
candleindark wants to merge 1 commit intomasterfrom
Open
Replace discriminated unions with simple unions in models#385candleindark wants to merge 1 commit intomasterfrom
candleindark wants to merge 1 commit intomasterfrom
Conversation
Removes the use of discriminated unions in favor of plain `Union[...]` for the `wasAssociatedWith`, `contributor`, and `about` fields. This has no effect on validation correctness since each union member has a distinct `schemaKey: Literal[...]` value, allowing Pydantic's smart union mode to resolve the correct type. It also enables translation to LinkML via pydantic2linkml since LinkML has no comparable feature to discriminated unions (dandi/pydantic2linkml#39). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
I would like to see the effect on schema. DONE -- the diff: see/show the diff on jsonschema! I am surprised that our workflow didn't run at all -- we might want it to still run to visualize the diff, and then do its decision making on either to fail or not.... I will add release label just for that for now. We might want just to make it still run although not do categories 
TODO: add to PR description analysis of why we had them to start with and analysis on possible effects on meditor |
yarikoptic
added
patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the use of discriminated unions in favor of plain
Union[...]for thewasAssociatedWith,contributor, andaboutfields.This has no effect on validation correctness: each union member has a distinct
schemaKey: Literal[...]value, so Pydantic's smart union mode resolves the correct type without a discriminator.The primary motivation is to enable translation to LinkML via pydantic2linkml, since LinkML has no comparable feature to discriminated unions (see dandi/pydantic2linkml#39).
Test plan
240 passed, 3 skipped)🤖 Generated with Claude Code