Skip to content

Make order of notes consistent #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
candleindark merged 3 commits into from
Mar 17, 2026
Merged

Make order of notes consistent #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cc1a04
Make order of notes consistent
yarikoptic Mar 13, 2026
8c9e1f4
feat: Sort notes in slot definition for consistent order
candleindark Mar 17, 2026
b070ef9
perf: perform sorting of class notes in place
candleindark Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/pydantic2linkml/gen_linkml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,9 @@ def attach_note(note: str) -> None:
slots.sort(key=str.casefold)
slot_usage.sort(key=lambda s: s.name.casefold())

# Ensure notes are sorted in a consistent order
notes.sort()

return ClassDefinition(
model.__name__,
description=(
Expand Down Expand Up @@ -448,6 +451,10 @@ def generate(self) -> SlotDefinition:
# Shape the contained slot according to core schema of the corresponding field
self._shape_slot(self._field_schema.schema)

# Ensure the notes in the slot definition are sorted in a consistent order
assert isinstance(self._slot.notes, list)
self._slot.notes.sort()

self._used = True
return self._slot

Expand Down
Loading