test: improve assertions in test_union_schema#40
Merged
candleindark merged 2 commits intodandi:mainfrom Mar 19, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Union[int, Union[str, Bar1]]),verifying that nested unions are flattened correctly.
test_union_schemato assert the fullSlotDefinitionvia==rather than checking individual attributes, makingassertions more complete and consistent with the new nested-union case.
notes=slot.notesis used in theSlotDefinitioncomparison (instead ofunittest.mock.ANY) becauseSlotDefinition.__eq__serializes fields before comparing, which causesANYto be treated as the literal string'<ANY>'. Note content is stillverified separately with
in_exactly_one_string.Test plan
hatch run test.py3.10:pytest tests/test_gen_linkml.py::TestSlotGenerator::test_union_schema🤖 Generated with Claude Code