fix: handle YAMLError from schema_yml in apply_schema_overlay#45
Merged
candleindark merged 1 commit intodandi:mainfrom Mar 26, 2026
Merged
Conversation
Wrap yaml.safe_load(schema_yml) in a try/except so invalid YAML raises ValueError, matching the behaviour of apply_yaml_deep_merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_schema_overlaywas not catchingyaml.YAMLErrorfromyaml.safe_load(schema_yml), so invalid YAML inschema_ymlwouldpropagate as a raw
YAMLErrorinstead of the documentedValueError.try/except yaml.YAMLErrorand re-raise asValueError, matching the existing behaviour ofapply_yaml_deep_merge.:raises ValueError:docstring line accordingly.test_schema_yml_invalid_yaml_raises_value_errortoTestApplySchemaOverlay, mirroring the equivalent test inTestApplyYamlDeepMerge.Test plan
hatch run test.py3.10:pytest tests/test_tools.py::TestApplySchemaOverlay— all 11 tests passruff check .— no issueshatch run types:check— no new errors introduced🤖 Generated with Claude Code